fix: support cross-origin iframe snapshots#1048
Open
Zqian007 wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: support cross-origin iframe snapshots#1048Zqian007 wants to merge 1 commit intovercel-labs:mainfrom
Zqian007 wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
…n TCP bind (vercel-labs#1041) On Windows the daemon derives a TCP port from the session name via a djb2 hash (e.g. "default" → 50838). On many machines this port falls inside Hyper-V's excluded port range (winnat), causing EACCES on bind and preventing the daemon from starting. Changes: - daemon: try the hash-derived port first; on failure, bind to port 0 (OS-assigned) and write the actual port to the .port file - client (connection.rs, stream.rs): read the .port file to discover the daemon's actual port, falling back to the hash if the file is absent - run_daemon: guard .sock file operations with #[cfg(unix)] and add .port file cleanup for #[cfg(windows)] Fixes vercel-labs#390 Co-authored-by: ctate <[email protected]>
Zqian007
force-pushed
the
fix-cross-iframe
branch
from
0cdc126 to
e9e25cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proactively attach to untracked iframe targets via Target.getTargets
before taking a snapshot, ensuring cross-origin iframes that were
missed during Target.attachedToTarget events are captured.
In snapshot.rs, fall back to dedicated iframe sessions for cross-origin
iframes when resolve_iframe_frame_id fails due to same-origin policy,
instead of silently skipping them.