Skip to content

fix: inline VS Code webviews in snapshots#1013

Open
zhanba wants to merge 1 commit intovercel-labs:mainfrom
zhanba:codex/vscode-webview-snapshot
Open

fix: inline VS Code webviews in snapshots#1013
zhanba wants to merge 1 commit intovercel-labs:mainfrom
zhanba:codex/vscode-webview-snapshot

Conversation

@zhanba
Copy link
Copy Markdown
Contributor

@zhanba zhanba commented Mar 25, 2026

Summary

  • track VS Code webview iframe targets so their sessions are available to snapshotting
  • resolve the nested active-frame inside VS Code webviews when taking snapshots
  • reuse the same frame lookup helper in frame selection and add focused VS Code regression coverage

Testing

  • cargo test vscode --manifest-path cli/Cargo.toml
  • cargo fmt --manifest-path cli/Cargo.toml -- --check

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 25, 2026

@zhanba is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@zhanba
Copy link
Copy Markdown
Contributor Author

zhanba commented Mar 26, 2026

@ctate would you consider this pr? it is important as VSCode extension api forces all extensions to use this two level nested iframe structure, and agent-browser can't work with it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant