fix(end-to-end): regenerate inputs #363
Conversation
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "cca-platform-token": { | |||
| "cca-platform-challenge": "5QHHS9edCpI1N1heeR7DUBI+gaqXUB34EkQCITSCxVM=", | |||
There was a problem hiding this comment.
I thought the idea with the claims in CCA Platform, was to not set the challenge here, but to calculate using Hash of Realm Public Key using the hash algorithm specified in the token, isn't it?
There was a problem hiding this comment.
Yes, this is effectively redundant. The value is what would be computed anyway by ccatoken.Evidence.bind(). I set it while experimenting a bit. It can be left in or removed; it makes no difference.
There was a problem hiding this comment.
thanks for the clarification, i think, it is more clear to the reader, it sends more correct message, if we do not hard code it here, so I suggest we remove it! Rest all changes LGTM!
yogeshbdeshpande
left a comment
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
just a question!
yogeshbdeshpande
left a comment
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
see minor nit!
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "cca-platform-token": { | |||
| "cca-platform-challenge": "5QHHS9edCpI1N1heeR7DUBI+gaqXUB34EkQCITSCxVM=", | |||
There was a problem hiding this comment.
thanks for the clarification, i think, it is more clear to the reader, it sends more correct message, if we do not hard code it here, so I suggest we remove it! Rest all changes LGTM!
Signed-off-by: Thomas Fossati <[email protected]>
thomas-fossati
force-pushed
the
e2e-fix
branch
from
932edcf to
b3bc758
Compare
Adjust CCA token templates and regenerate demo files