fix: replace ExtensionValue with RawValue #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
setrofim
force-pushed
the
ext-values
branch
3 times, most recently
from
8af8c75 to
0855a8d
Compare
fitzthum
approved these changes
Jan 15, 2025
fitzthum
left a comment
fitzthum
left a comment
There was a problem hiding this comment.
LGTM
Tested this branch with Trustee and it seems good.
Both these enums have similar definitions and serve similar purposes. To minimize duplication, remove ExtensionValue and replace it with RawValue inside Extensions implementation. Additional functionality of ExtensionValue is added to RawValue, and ExtensionKind is renamed to RawValueKind. This also resolves issues with serialization of extensions, as ExtensionValue serialzation for maps and sequences was not implemented correctly, unlike in RawValue. Signed-off-by: Sergei Trofimov <[email protected]>
Elide some needless lifetimes that are now being reported by clippy. Signed-off-by: Sergei Trofimov <[email protected]>
To reflect the corresponding license change in the dependencies. Signed-off-by: Sergei Trofimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both these enums have similar definitions and serve similar purposes. To minimize duplication, remove ExtensionValue and replace it with RawValue inside Extensions implementation. Additional functionality of ExtensionValue is added to RawValue, and ExtensionKind is renamed to RawValueKind.
This also resolves issues with serialization of extensions, as ExtensionValue serialzation for maps and sequences was not implemented correctly, unlike in RawValue.
This addresses #32