Fix protoc compilation requirements issue #32 #53
Conversation
kallal79
requested review from
cowbon,
deeglaze,
iolivergithub,
jraman567 and
thomas-fossati
as code owners
kallal79
force-pushed
the
fix/protoc-compilation-requirements
branch
from
df99c2b to
bb4df4a
Compare
jraman567
left a comment
jraman567
left a comment
There was a problem hiding this comment.
Hi @7908837174 , thank you for this PR. The change to go.uber.org/mock/gomock is causing build failure. Could you please check it out. Thank you!
|
Ok, I'll check it out.
…On Tue, 23 Sept, 2025, 21:25 Jag Raman, ***@***.***> wrote:
***@***.**** commented on this pull request.
Hi @7908837174 <https://github.com/7908837174> , thank you for this PR.
The change to go.uber.org/mock/gomock is causing build failure. Could you
please check it out. Thank you!
—
Reply to this email directly, view it on GitHub
<#53 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLR2IIN2U6C2AKG3FQRB5TD3UFUP7AVCNFSM6AAAAACHFC7GHSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENJYGY4DKNJZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
kallal79
force-pushed
the
fix/protoc-compilation-requirements
branch
from
a2e8f6e to
dc557f0
Compare
|
ready for the review! |
|
Kindly requesting review from sir @yogeshbdeshpande @setrofim @mcdonc @thomas-fossati jraman567 for PR #53 |
kallal79
force-pushed
the
fix/protoc-compilation-requirements
branch
from
1e3aa47 to
7d7a5be
Compare
|
Gomock Consistency Issue Fixed @jraman567 @cowbon @deeglaze @iolivergithub @thomas-fossati - This should now be ready for review with all test issues resolved. |
|
Kindly requesting review from sir @yogeshbdeshpande @setrofim @thomas-fossati @cowbon for PR #53 .. |
|
It's necessary to resolve all conflicts before requesting any review, period. |
|
Conflicts Resolved ** Issues Fixed:** Resolved dependency version conflicts in go.mod and go.sum All existing tests pass |
Signed-off-by: Ian Chin Wang <[email protected]> Signed-off-by: Kallal Mukherjee <[email protected]>
Now users may pick the desired output content type of each sub-attester
by specifying field "content-type" in "attester-selection" as shown in
the following example:
"attester-selection": {
"mock-tsm":{
"content-type": "application/vnd.veraison.configfs-tsm+json",
"privilege_level": "3"
}
}
Signed-off-by: Ian Chin Wang <[email protected]>
Signed-off-by: Kallal Mukherjee <[email protected]>
"selecton" to "selection" Signed-off-by: Ian Chin Wang <[email protected]> Signed-off-by: Kallal Mukherjee <[email protected]>
- Add comprehensive protoc installation documentation for multiple platforms - Add dependency checks in Makefile with clear error messages - Add automated protoc installation support (install-protoc target) - Add complete dev environment setup (setup-dev target) - Add help target with comprehensive build instructions - Fix protoc-gen-go-grpc package path in Makefile and tools.go - Update mock imports to use go.uber.org/mock/gomock - Regenerate mocks with correct dependencies - Improve error handling for missing dependencies - Fix default Makefile target This resolves the build failure when protoc is not installed by: 1. Providing clear installation instructions 2. Adding dependency verification 3. Offering automated installation options 4. Giving helpful error messages when dependencies are missing Fixes veraison#32 Signed-off-by: GitHub Copilot <[email protected]> Signed-off-by: Kallal Mukherjee <[email protected]>
- Update tools.go to use github.com/golang/mock/mockgen for consistency - Update Makefile install-tools to use github.com/golang/mock/mockgen - Regenerated mocks now use go.uber.org/mock/gomock (latest version) - Updated api/server_test.go to use go.uber.org/mock/gomock to match mocks - All tests pass and build succeeds This resolves the GitHub Action build failure: 'cannot use ctrl (variable of type *go.uber.org/mock/gomock.Controller) as *github.com/golang/mock/gomock.Controller value in argument to NewMockIManager' The fix ensures consistent gomock usage throughout the codebase by using the modern go.uber.org/mock package which is the successor to github.com/golang/mock. Signed-off-by: Kallal Mukherjee <[email protected]>
- Remove github.com/golang/mock dependency from go.mod - Update tools.go to use go.uber.org/mock/mockgen - Update Makefile to install go.uber.org/mock/mockgen@latest - Update CI workflow to use go.uber.org/mock/mockgen@latest - Clean up go.sum dependencies This resolves the type mismatch between *go.uber.org/mock/gomock.Controller and *github.com/golang/mock/gomock.Controller that was causing test failures. Signed-off-by: Kallal Mukherjee <[email protected]>
- Use main branch dependency versions (kin-openapi v0.131.0, grpc v1.64.0, etc.) - Keep protoc-gen-go-grpc dependency added in PR - Maintain consistency with go.uber.org/mock migration - Run go mod tidy to ensure clean dependency resolution - All tests pass and build succeeds Signed-off-by: Kallal Mukherjee <[email protected]>
kallal79
force-pushed
the
fix/protoc-compilation-requirements
branch
from
ba708ac to
1e5a810
Compare
|
Kindly requesting review from sir @yogeshbdeshpande @setrofim @thomas-fossati @cowbon for PR #53 .. |
|
thanks for the update!
…On Wed, 29 Oct, 2025, 01:45 icwang, ***@***.***> wrote:
Closed #53 <#53>.
—
Reply to this email directly, view it on GitHub
<#53 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLR2IILCXYXG5MLKJBAYPFD3Z7FHPAVCNFSM6AAAAACHFC7GHSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGU3DGNJVHA3TIMY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
3 participants
This resolves the build failure when protoc is not installed by:
Fixes #32