Enable sub-attesters content type selection and minor fixes #43
+65
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowbon
requested review from
deeglaze,
iolivergithub,
jraman567 and
thomas-fossati
as code owners
cowbon
force-pushed
the
cowbon-patch-8
branch
2 times, most recently
from
fb9331a to
c970d61
Compare
Contributor
thomas-fossati
left a comment
thomas-fossati
left a comment
There was a problem hiding this comment.
LGTM, thanks! There’s just one easy to fix bug in the documentation.
README.md
Outdated
| the following example: | ||
| ```json | ||
| "attester-selection": { | ||
| mocktsm:{ |
Contributor
There was a problem hiding this comment.
invalid JSON (missing quotes)
Suggested change
| mocktsm:{ | |
| “mocktsm”: { |
Also, should it be "mock-tsm” instead?
Collaborator
Author
There was a problem hiding this comment.
Yes, the right name should be mock-tsm (has a dash)
Merged
thomas-fossati
approved these changes
Sep 2, 2025
Contributor
thomas-fossati
left a comment
thomas-fossati
left a comment
There was a problem hiding this comment.
thanks for addressing my comments!
Signed-off-by: Ian Chin Wang <[email protected]>
Now users may pick the desired output content type of each sub-attester
by specifying field "content-type" in "attester-selection" as shown in
the following example:
"attester-selection": {
"mock-tsm":{
"content-type": "application/vnd.veraison.configfs-tsm+json",
"privilege_level": "3"
}
}
Signed-off-by: Ian Chin Wang <[email protected]>
"selecton" to "selection" Signed-off-by: Ian Chin Wang <[email protected]>
cowbon
force-pushed
the
cowbon-patch-8
branch
from
4b79dd8 to
2845ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now users may pick the desired output content type of each sub-attester
by specifying field "content-type" in "attester-selection" as shown in
the following example: