Add attester specific option support #40
Merged
+273
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowbon
requested review from
deeglaze,
iolivergithub,
jraman567 and
thomas-fossati
as code owners
Contributor
thomas-fossati
left a comment
thomas-fossati
left a comment
There was a problem hiding this comment.
Looks awesome! Again a few silly comments inlined that should be easy to fix.
cowbon
force-pushed
the
cowbon-patch-4
branch
2 times, most recently
from
2414f14 to
77af9d6
Compare
Collaborator
Author
|
Thanks @thomas-fossati for your constructive suggestions, and I have adopted all of them. |
Add a way for users to specify attester-specific options in /chares endpoint. Each attesters is responsible for parsing the parameters. If the options are not supplied in the request, the attester should continue with the default options. Options specified for unavailable attesters are ignored by ratsd. Signed-off-by: Ian Chin Wang <[email protected]>
MockTSM now takes the support of options, only privilege_level is
supported at this time. The schema is defined as the following:
mocktsm:{"privilege_level": "$level"}. Replace $level with number 0-3
Signed-off-by: Ian Chin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not a simple task to deal with exposing the custom options for each attester. This PR assumes the users will know the input format of each attester beforehand. The following is an example of the request with the options
The selection of what goes into the EAT, however, is beyond the scope of this PR, and will be added soon.