feat!: update CCA token to draft-ffm-rats-cca-token-00 #45
+80
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also requires updating the following dependencies: github.com/veraison/ccatoken v1.2.0 -> v1.3.1 github.com/veraison/go-cose v1.1.0 -> v1.3.0 github.com/veraison/psatoken v1.2.0 -> @latest BREAKING CHANGE: the produced CCA token uses a different encoding for the RAK public key. Signed-off-by: Thomas Fossati <[email protected]>
thomas-fossati
force-pushed
the
ccatoken-upgrade
branch
from
4264d88 to
0f62953
Compare
Signed-off-by: Thomas Fossati <[email protected]>
Signed-off-by: Thomas Fossati <[email protected]>
thomas-fossati
force-pushed
the
ccatoken-upgrade
branch
from
a70e799 to
3988581
Compare
thomas-fossati
requested review from
paulhowardarm,
setrofim and
yogeshbdeshpande
paulhowardarm
approved these changes
Nov 28, 2024
Contributor
paulhowardarm
left a comment
paulhowardarm
left a comment
There was a problem hiding this comment.
LGTM (conceptually, at least, I'm not expert in this code base) - thanks for jumping on this.
yogeshbdeshpande
approved these changes
Nov 28, 2024
Contributor
yogeshbdeshpande
left a comment
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
LGMT! Thanks for the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also requires updating the following dependencies:
github.com/veraison/ccatoken v1.2.0 -> v1.3.1
github.com/veraison/go-cose v1.1.0 -> v1.3.0
github.com/veraison/psatoken v1.2.0 -> @latest
BREAKING CHANGE: the produced CCA token uses a different encoding for the RAK public key.
Fix #44