fix(demo): correct protoc-gen-go installation instructions (fixes #59) #64
+78
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aison#59) Clarify the distinction between protoc and protoc-gen-go installation: - protoc is the Protocol Buffer compiler - protoc-gen-go is the Go language plugin for protoc - Both are required for generating Go code from .proto files Updated both CCA and PSA demo documentation to provide clear, platform-specific installation instructions with troubleshooting guidance. Fixes veraison#59 Signed-off-by: 7908837174 <[email protected]>
kallal79
force-pushed
the
fix-protoc-installation-instructions-issue-59
branch
from
eb2618d to
02ca03a
Compare
Author
|
Thanks @setrofim for the approval Kindly requesting a review from @yogeshbdeshpande as well. |
Contributor
|
@7908837174 Have you tried on a clean machine the modified instructions to validate the flow for correctness..? |
Author
Yes — the updated bash instructions were successfully tested on a clean Ubuntu system, confirming full toolchain setup, PATH resolution, and demo execution without inherited configs. |
Author
|
Kindly requesting review from sir @yogeshbdeshpande for PR veraison/services#344 |
Author
|
Big thanks to @setrofim and @yogeshbdeshpande for your thoughtful reviews and support on PR #64 .. |
Contributor
|
Thanks to you @7908837174 for working hard on issues and fixing the same! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the confusing protoc-gen-go build instructions identified in #59.
Problem
The original instructions incorrectly mixed protoc installation with protoc-gen-go plugin installation, referencing non-existent versions.
Solution
Files Modified
Testing
Closes #59