Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VendrSyncHandlerBase to reflect changes in latest uSync API #5

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

Xanashi
Copy link
Contributor

@Xanashi Xanashi commented Jan 25, 2021

Fixes compilation with latest uSync and Umbraco packages
Also fixes a NullReference exception when importing countries with no values set in the currency, payment, and/or shipping fields

@mattbrailsford
Copy link
Member

Hey @Xanashi

Sorry, I totally didn't see this PR so apologies for the late reply.

The only thing that concerns me in the PR is that you seem to updated a whole lot of dependencies. Is this all necessary as this would force people using this package to upgrade to a minimum Vendr version of 1.4.1 amongst other dependencies.

@Xanashi
Copy link
Contributor Author

Xanashi commented Mar 15, 2021

Hey Matt,

Sorry I went a bit overboard with the package updates (trying to make sure everything compiled with the latest Umbraco).
I've redone the PR with just the necessary changes, and the changes separated in two relevant commits.
Hope this is better. :)

@mattbrailsford
Copy link
Member

Perfect! that's much clearer and focused thank you 👍

@mattbrailsford mattbrailsford merged commit e9040ad into vendrhub:dev Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants