Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Handlers/Serializers #1

Merged
merged 13 commits into from
Sep 24, 2020
Merged

All Handlers/Serializers #1

merged 13 commits into from
Sep 24, 2020

Conversation

KevinJump
Copy link
Collaborator

All handlers and serializers for vendr - (still in progress).

@KevinJump
Copy link
Collaborator Author

Hi, I want to make this PR draft, can't find the button 😞

@KevinJump
Copy link
Collaborator Author

I think this is working now, I have copied the build scripts over, but you should definitely check them.

I've changed one line of the build.cmd file, to use vswhere.exe (in the tools folder) to find msbuild.exe because it wasn't where the script was looking on my machine.

@KevinJump
Copy link
Collaborator Author

I am going to call this 'done' now, if you could test and confirm it works.

attached is a uSync folder from the demo store, you should be able to import this into a blank site (the media files will be missing for the images, but it all should work).

uSync.zip

@mattbrailsford
Copy link
Member

Awesome! Thanks @KevinJump I'll take a look and test this out 👍

Stellar work ✨💫

@mattbrailsford
Copy link
Member

Just tested this and works really nicely. Noticed the Vendr folder was set to vendr yet all other folder names were title case so just updated this to be Vendr. I updated the group name too but not sure where that gets used.

I noticed when installing the Umbraco package the handlers don't get registered in the config. Do we need a package action / migration or something for these?

I do think there might be a potential future issue because deletes do a soft delete and so uSync thinks trying to re-import is an update as the records already exist in the db. Not sure what would / should happen here.

@KevinJump
Copy link
Collaborator Author

yeah the group name is only used to group them together and get the dictionary value (e.g usync_{group}-import) and i don't think that is case sensitve.

yes there is a transform for the config for the nuget package, I am fairly sure i have code lying around somewhere to apply a transform as a package action (then you don't need two versions of anything) - will see if i can remember what project that was in).

@KevinJump
Copy link
Collaborator Author

this was in v7 - https://github.com/KevinJump/uSync/blob/v4_master/Jumoo.uSync.ContentMappers/PackageActions.cs might need to check it works on v8.

(it worked like this.... <Action runat="install" undo="false" alias="UCM.TransformConfig" file="~/config/uSyncCore.config" xdtfile="~/app_data/temp/ucm/uSyncCore.config"></Action> )

@mattbrailsford
Copy link
Member

Great stuff, thanks @KevinJump I'll take a look at this 👍

@mattbrailsford
Copy link
Member

I've taken a bunch of screenshots and a nice video to display on the future add-on page for vendr.net 😁

Settings - localhost

@mattbrailsford mattbrailsford merged commit a8dd269 into dev Sep 24, 2020
@mattbrailsford mattbrailsford deleted the handlers branch September 24, 2020 08:38
@mattbrailsford
Copy link
Member

I think this is more than good enough to merge in. Will take a look at the package action from within the dev branch. Thanks again for the amazing work @KevinJump 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants