-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All Handlers/Serializers #1
Conversation
Hi, I want to make this PR draft, can't find the button 😞 |
I think this is working now, I have copied the build scripts over, but you should definitely check them. I've changed one line of the build.cmd file, to use vswhere.exe (in the tools folder) to find msbuild.exe because it wasn't where the script was looking on my machine. |
I am going to call this 'done' now, if you could test and confirm it works. attached is a uSync folder from the demo store, you should be able to import this into a blank site (the media files will be missing for the images, but it all should work). |
Awesome! Thanks @KevinJump I'll take a look and test this out 👍 Stellar work ✨💫 |
…er uSync folders appear to be title case
Just tested this and works really nicely. Noticed the Vendr folder was set to I noticed when installing the Umbraco package the handlers don't get registered in the config. Do we need a package action / migration or something for these? I do think there might be a potential future issue because deletes do a soft delete and so uSync thinks trying to re-import is an update as the records already exist in the db. Not sure what would / should happen here. |
yeah the group name is only used to group them together and get the dictionary value (e.g usync_{group}-import) and i don't think that is case sensitve. yes there is a transform for the config for the nuget package, I am fairly sure i have code lying around somewhere to apply a transform as a package action (then you don't need two versions of anything) - will see if i can remember what project that was in). |
this was in v7 - https://github.com/KevinJump/uSync/blob/v4_master/Jumoo.uSync.ContentMappers/PackageActions.cs might need to check it works on v8. (it worked like this.... |
Great stuff, thanks @KevinJump I'll take a look at this 👍 |
I think this is more than good enough to merge in. Will take a look at the package action from within the dev branch. Thanks again for the amazing work @KevinJump 🙏 |
All handlers and serializers for vendr - (still in progress).