-
Notifications
You must be signed in to change notification settings - Fork 18
Add test for validate_all with adorned node and ignore undefined outputs #3447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dvargas92495
merged 2 commits into
main
from
devin/1766508253-test-validate-all-adornment
Dec 23, 2025
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DevinAI what happens if we add an
"error"output here and change nothing else about the test?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this - adding an
"error"output tothen_outputscauses aWorkflowInitializationExceptionwith the message "Failed to validate mock node executions".The root cause is a
NodeException: Unexpected outputs: {'error'}raised fromBaseOutputs.__init__because the inner wrapped node'sOutputsclass only declaresresult: str, noterror.The validation correctly rejects outputs that aren't declared on the node's Outputs class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a second test that exhibits this.
In that test, ensure that we pass. Doing so will require us updating the business logic of deserializing node outputs to ignore any outputs that are not defined in the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DevinAI apply the feedback I just left in this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! I've added a second test (
test_mocks__validate_all__ignores_undefined_outputs) that includes an"error"output inthen_outputsand verifies it's ignored.I also updated
BaseOutputs.__get_pydantic_core_schema__to filter out undefined outputs during deserialization. The strict validation inBaseOutputs.__init__is preserved for normal runtime construction.