[APO-2207] Use unique class names for nested workflow classes in codegen #3249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating nested workflow contexts for inline subworkflow nodes, the nested workflow class name was created using createPythonClassName() directly without checking for collisions with existing class names. This caused issues when a node in a subworkflow had the same name as the outer inline subworkflow node, resulting in identical CodeResourceDefinition values for both the base node class and the nested workflow class. This fix uses workflowContext.getUniqueClassName() and addUsedClassName() to ensure nested workflow class names are unique within the shared classNames registry, similar to how node class names are handled. Co-Authored-By: [email protected] <[email protected]>
Contributor
|
@codex review |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Tests that when an internal node has the same name as what the nested workflow class would be named, the nested workflow class gets a unique name. This verifies the fix in nested-workflow-base.ts that uses getUniqueClassName() instead of createPythonClassName() directly. Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes class name collision in codegen when a node in a subworkflow has the same name as the outer inline subworkflow node. The nested workflow class name was bypassing the shared
classNamesregistry, so now it usesgetUniqueClassName()+addUsedClassName()to ensure uniqueness.Review & Testing Checklist for Human
MyNodeWorkflow1), not the nested workflow classNotes
nested workflow class name collisionthat specifically reproduces the APO-2207 scenario