Skip to content

Conversation

@fern-api
Copy link
Contributor

@fern-api fern-api bot commented Nov 5, 2025

This PR regenerates code to match the latest API Definition.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 169 to 172
end
unless request_options&.api_version.nil?
req.headers["X-API-Version"] = request_options.api_version
else
req.headers["X-API-Version"] = "2025-07-30"
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Removing default X-API-Version causes unpinned API requests

The generated clients no longer fall back to a default API version. In previous releases, each request set "X-API-Version" to "2025-07-30" whenever the caller did not pass RequestOptions#api_version; the new code simply skips the header when request_options is nil. Upgrading to this SDK will therefore change every call to rely on the server’s implicit default (or fail if the header is required), which is a backward-incompatible behavioral change for consumers who expect requests to stay pinned to 2025-07-30 without custom configuration. Consider retaining an explicit default value or updating the constant rather than dropping the header entirely.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant