fix(controller): propagate context during backup request preparation - #10621
Open
abhayrajjais01 wants to merge 1 commit into
Open
abhayrajjais01 wants to merge 1 commit into
abhayrajjais01 wants to merge 1 commit into
Conversation
👷 Deploy request for velero pending review.Visit the deploys page to approve it
|
Pass caller-provided context.Context through cluster API queries during backup request preparation and snapshot location validation, ensuring context cancellation and deadlines are properly respected. Closes velero-io#10620 Signed-off-by: Abhayraj Jaiswal <abhayraj916146@gmail.com>
abhayrajjais01
force-pushed
the
fix/backup-request-context
branch
from
October 2, 2026 11:25
627aede to
ad68403
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Joeavaikath
approved these changes
Oct 2, 2026
Joeavaikath
left a comment
Joeavaikath
left a comment
Collaborator
There was a problem hiding this comment.
This is similar context threading to #10605, lgtm!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
In
pkg/controller/backup_controller.go,prepareBackupRequestreceives actx context.Contextparameter from the reconciler, but was passingcontext.Background()when:storage.ListBackupStorageLocations)b.kbClient.Get)b.kbClient.List)validateAndGetSnapshotLocations)This change:
ctxthrough all cluster API calls during backup request preparation and snapshot location validation.TestValidateAndGetSnapshotLocationsverifying that context cancellation is properly honored.Does your change fix a particular issue?
Fixes #10620
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.