feat(evm-utils/evm-state): move velas-chain to fast_rlp tag - #442
Closed
dj8yfo wants to merge 1 commit into
Closed
Conversation
[ ] checkout develop of `velas-chain`
├── [ ] patch `fast-rlp` so that it depends directly on `primitive-types` and `ethbloom`
├── [ ] later make sure that `src/walker/` and `src/walker/inspector` is not duplicated
└── [ ] make compile stubbed
├── [ ] __evm-utils/evm-state/src/types.rs__:
│ ├── [ ] `block_header_old_rlp::BlockHeader`
│ │ ├── [ ] new
│ │ │ ├── [✓] `BlockHeader::hash`, `Encodable` stub
│ │ │ └── [ ] roundtrip test
│ │ └── [ ] methods (unlinked with `#cfg[test]`)
│ │ └── [✓] hash -> hash_old_rlp; hash
│ │ └── [ ] `OldEncodable::rlp_append` -> `Encodable::{encode, length}`
│ │ ├── [ ] rlp_append_legacy -> rlp_append_legacy_old; *rlp_append_legacy*
│ │ └── [ ] rlp_append_newer -> rlp_append_newer_old; *rlp_append_newer*
│ ├── [ ] `account_old_rlp::Account`
│ │ ├── [ ] new
│ │ │ ├── [✓] Encodable stub, Decodable stub
│ │ │ └── [ ] roundtrip test
│ │ └── [ ] methods (unlinked with `#cfg[test]`)
│ │ ├── [ ] `OldEncodable::rlp_append` -> `Encodable::{encode, length}`
│ │ └── [ ] `OldDecodable::decode` -> `Decodable::decode`
│ ├── [ ] `account_state_old_rlp::AccountState`
│ │ ├── [ ] new
│ │ │ ├── [✓] Encodable stub, Decodable stub
│ │ │ └── [ ] roundtrip test
│ │ ├── [ ] methods (unlinked with `#cfg[test]`)
│ │ │ ├── [ ] `OldEncodable::rlp_append` -> `Encodable::{encode, length}`
│ │ │ └── [ ] `OldDecodable::decode` -> `Decodable::decode`
│ │ └── [ ] subtypes
│ │ └── [ ] `code_old_rlp::Code`
│ │ ├── [ ] new
│ │ │ ├── [✓] Encodable stub, Decodable stub
│ │ │ └── [ ] roundtrip test
│ │ └── [ ] methods (unlinked with `#cfg[test]`)
│ │ ├── [ ] `OldEncodable::rlp_append` -> `Encodable::{encode, length}`
│ │ └── [ ] `OldDecodable::decode` -> `Decodable::decode`
│ ├── [ ] `ethereum_receipt_old_rlp::EthereumReceipt`
│ │ ├── [ ] new
│ │ │ ├── [✓] Encodable stub, Decodable stub
│ │ │ └── [ ] roundtrip test
│ │ └── [ ] methods (unlinked with `#cfg[test]`)
│ │ ├── [ ] `OldEncodable::rlp_append` -> `Encodable::{encode, length}`
│ │ └── [ ] `OldDecodable::decode` -> `Decodable::decode`
│ ├── [ ] `tests`
│ │ ├── [ ] `tests::TestHeader`
│ │ │ └── [ ] ...
│ │ ├── [ ] `old_rlp` mod
│ │ │ ├── [ ] `fn block_1_testnet_newest_rlp_without_tx() {`
│ │ │ └── [ ] `fn block_1_testnet_newest_rlp_with_tx() {`
│ │ └── [ ] stays where it is`#[test] fn block_1_testnet_legacy_rlp() {`
│ └── [ ] remove `use impl_rlp::impl_fixed_hash_rlp;`
└── [ ] __evm-utils/evm-state/src/transactions.rs__:
├── [ ] `transaction_in_receipt_old_rlp::TransactionInReceipt`
│ ├── [ ] methods
│ │ ├── [✓] Encodable stub
│ │ ├── [✓] Decodable stub
│ │ └── [ ] actual impl and roundtrip test
│ └── [ ] subtypes
│ ├── [ ] `transaction_old_rlp::Transaction`
│ │ ├── [ ] methods
│ │ │ ├── [ ] signing_rlp_append
│ │ │ ├── [ ] signing_hash
│ │ │ ├── [ ] rlp_append_consistend
│ │ │ ├── [ ] Encodable stub
│ │ │ └── [ ] Decodable stub
│ │ └── [ ] subtypes
│ │ └── [ ] `transaction_action_old_rlp::TransactionAction`
│ │ └── [ ] methods
│ │ ├── [ ] Encodable stub
│ │ └── [ ] Decodable stub
│ └── [ ] `unsigned_transaction_with_caller_old_rlp::UnsignedTransactionWithCaller`
│ └── [ ] methods
│ ├── [ ] Encodable stub
│ └── [ ] Decodable stub
└── [ ] `unsigned_transaction_old_rlp::UnsignedTransaction`
├── [ ] methods
│ ├── [ ] Encodable stub
│ └── [ ] Decodable stub
└── [ ] subtypes
└── [ ] `transaction_action_old_rlp::TransactionAction`
dj8yfo
force-pushed
the
fast_rlp_move_tag
branch
2 times, most recently
from
April 21, 2023 17:08
7b2aeb6 to
62949e2
Compare
Contributor
Author
|
Closed in favor of #443 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably will be rejected as scope is too big for first iteration.
A smaller version with both libs used will be merged first instead.
Problem
Implement fast-rlp serialization for all ethereum types, check encoding hasn't changed compared to rlp
Summary of Changes
Fixes #