Skip to content

Feature(evm-loader): derive BorshSchema, silence dead code warnings #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gBaGu wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feature(evm-loader): derive BorshSchema, silence dead code warnings #372

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b3e8dd
Feature(evm-loader): derive BorshSchema, silence dead code warnings
gBaGu Oct 5, 2022
05ba23b
Feature(cli): add subcommand for Borsh schema generation
gBaGu Oct 17, 2022
dc946a5
Fix(cli): fix tests
gBaGu Oct 17, 2022
a43338d
fix types for schema generation
gBaGu Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions evm-utils/programs/evm_loader/src/instructions/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#![allow(dead_code)]
use super::scope::*;
use borsh::{BorshDeserialize, BorshSerialize};
use borsh::{BorshDeserialize, BorshSchema, BorshSerialize};
use evm_state::{Address, Transaction, UnsignedTransaction};
use serde::{Deserialize, Serialize};

Expand All @@ -10,8 +11,7 @@ pub const EVM_INSTRUCTION_BORSH_PREFIX: u8 = 255u8;
#[derive(
BorshSerialize,
BorshDeserialize,
// TODO: add schema generation custom command
// BorshSchema,
BorshSchema,
Clone,
Debug,
PartialEq,
Expand All @@ -37,12 +37,10 @@ impl FeePayerType {

/// Solana blockchain limit amount of data that transaction can have.
/// To get around this limitation, we use design that is similar to LoaderInstruction in sdk.

#[derive(
BorshSerialize,
BorshDeserialize,
// TODO: add schema generation custom command
// BorshSchema,
BorshSchema,
Clone,
Debug,
PartialEq,
Expand All @@ -52,8 +50,6 @@ impl FeePayerType {
Serialize,
Deserialize,
)]

// #[allow(clippy::dead_code)]
pub enum EvmBigTransaction {
/// Allocate data in storage, pay fee should be taken from EVM.
EvmTransactionAllocate { size: u64 },
Expand All @@ -65,8 +61,7 @@ pub enum EvmBigTransaction {
#[derive(
BorshSerialize,
BorshDeserialize,
// TODO: add schema generation custom command
// BorshSchema,
BorshSchema,
Clone,
Debug,
PartialEq,
Expand Down Expand Up @@ -96,8 +91,7 @@ impl ExecuteTransaction {
#[derive(
BorshSerialize,
BorshDeserialize,
// TODO: add schema generation custom command
// BorshSchema,
BorshSchema,
Clone,
Debug,
PartialEq,
Expand Down