fix: for interactive charts, changed cursor to pointer (also updated tests) #9305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessamineQ
changed the title
domoritz
requested changes
May 1, 2024
There was a problem hiding this comment.
I don't think this is quite right yet. For example in http://localhost:5173/editor/#/examples/vega-lite/dynamic_color_legend we show a pointer cursor but the selection is an interval selection with a brush. For brushes, the cursor should change for the whole chart (where you can draw the brush) and not change just because you hover over a mark. Think of it this way: an interval selection isn't a selection of a mark so the cursor should not be specific to the mark.
…point selection (rather than interval) and no binding
domoritz
requested changes
May 27, 2024
|
|
||
| let isPoint = false; | ||
| let isBind = false; | ||
| if (model.component.selection) { |
There was a problem hiding this comment.
this doesn't look right. What if there is one point selection and one point selection with bind. Then this would not work.
| } | ||
| } | ||
| } | ||
| interactive && isPoint && !isBind ? (model.markDef.cursor ??= 'pointer') : {}; |
|
Replaced by #9358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes #4155 (specifically for cursor over interactive bars)