Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a logger to embed init options #732

Open
wants to merge 6 commits into
base: next
Choose a base branch
from
Open

feat: Add a logger to embed init options #732

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e67761c
Add a logger to embed init options
challet Aug 4, 2021
a22deb0
update doc
challet Aug 4, 2021
24f1620
Update README.md
challet Aug 5, 2021
81065ec
rename an import
challet Aug 5, 2021
15a97f6
add a test
challet Aug 5, 2021
7c57477
Pass the logger to vegaLite
challet Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/embed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ async function _embed(

const mode = guessMode(spec, opts.mode);

let vgSpec: VgSpec = PREPROCESSOR[mode](spec, config);
let vgSpec: VgSpec = PREPROCESSOR[mode](spec, { ...config, logger });
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be added directly to the passed config, since the whole arg will be discarded when the mode is not 'vega-lite'


if (mode === 'vega-lite') {
if (vgSpec.$schema) {
Expand Down