fix(finalize): call embed finalize instead of view #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-vega ready! 🔨 Explore the source changes: 841d7b6 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-vega/deploys/6120ec691023e300082a3712 😎 Browse the preview: https://deploy-preview-421--react-vega.netlify.app |
domoritz
approved these changes
Aug 6, 2021
| if (view) { | ||
| action(view); | ||
| if (this.resultPromise) { | ||
| this.resultPromise |
There was a problem hiding this comment.
At some point, we should rewrite this to use a sync/await but that's out of scope for this pull request.
There was a problem hiding this comment.
i tried to keep the diff to a minimum set of changes
|
@kristw can you review this? |
|
@kristw could you take a look and merge this? |
kristw
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #383