react vega leaks memory

[domoritz]

In

react-vega/packages/react-vega/src/VegaEmbed.tsx

Line 139 in 64502df

view.finalize();

we only finalize the view but we need to call finalize from the embed result.

[ndobb]

@kristw is this the issuing causing #200?

In our app's usage of react-vega we'll potentially be mounting and unmounting the <Vega/> component frequently, so a fix (or guidance on how to fix ourselves) would be great.

[domoritz]

The fix should be pretty straightforward. Instead of calling finalize on the view, we should call it on the result from Vega-Embed. We do this in https://github.com/vega/svelte-vega now. It would be awesome if you could send a pull request.

[ndobb]

Happy to take a stab at a fix, and thanks for the pointer to svelte-vega.

[ndobb]

@domoritz please see PR at #403.

[kristw]

published [email protected]

[domoritz]

Thank you @kristw!