Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not jan main #20

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Not jan main #20

merged 6 commits into from
Dec 19, 2024

Conversation

veeso
Copy link
Owner

@veeso veeso commented Dec 19, 2024

#8 - Expose ignored fields

Fixes #8 as that issue was resolved by exposing invalid fields via the API but not ignored ones. Users may now access "raw" fields that ssh2-config normally ignores.

Description

  • I've updated README.md to reflect the changes
  • I've made it so that ignored fields can optionally be added to the unsupported_fields field of HostParams
  • I've added a new ParseRule to allow parsing unsupported fields

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • The changes I've made are Windows, MacOS, Linux compatible (or I've handled them using cfg target_os)
  • I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests

wait for a project maintainer to fulfill this section...

  • regression test: ...

@veeso veeso mentioned this pull request Dec 19, 2024
14 tasks
@veeso veeso merged commit 0d05ca8 into main Dec 19, 2024
4 checks passed
@veeso veeso deleted the not-jan-main branch December 19, 2024 09:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12409696750

Details

  • 35 of 139 (25.18%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-5.7%) to 93.664%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/params.rs 6 9 66.67%
src/parser/mod.rs 23 33 69.7%
src/parser/field.rs 6 97 6.19%
Files with Coverage Reduction New Missed Lines %
src/params.rs 1 98.56%
Totals Coverage Status
Change from base Build 12409444121: -5.7%
Covered Lines: 1700
Relevant Lines: 1815

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Expose ignored fields
3 participants