Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: overhaul #19

Merged
merged 3 commits into from
Dec 16, 2024
Merged

ci: overhaul #19

merged 3 commits into from
Dec 16, 2024

Conversation

crazyscot
Copy link
Contributor

@crazyscot crazyscot commented Dec 14, 2024

ISSUE 17 - Overhaul CI

Fixes #17. Coveralls report

Description

This branch necessarily incorporates PR #18.

  • Replace deprecated actions with more modern ones
  • Add rust-cache to the build step
  • Rebuild coverage workflow using taiki-e/cargo-llvm-cov
  • Run the various build steps with --locked
    • This could be controversial. This is what I do in my own repos, but I'm happy to back that out if preferred.
  • Include clippy fixes from style: fix clippy warnings #18

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • [N/A] I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [N/A] The changes I've made are Windows, MacOS, Linux compatible (or I've handled them using cfg target_os)
  • I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests

wait for a project maintainer to fulfill this section...

  • regression test: ...

.gitignore Outdated Show resolved Hide resolved
- use updated checkout and coveralls actions
- use dtolnay/rust-toolchain instead of actions-rs
- add rust-cache to build action
- run coverage against stable toolchain (not nightly)
- use cargo-llvm-cov to generate coverage data
- upload coverage report as a github artifact
- remove unnecessary apt step
@crazyscot
Copy link
Contributor Author

Updated as requested: Cargo.lock untracked, all instances of --locked removed from the workflows.

@crazyscot crazyscot requested a review from veeso December 16, 2024 09:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12349180208

Details

  • 42 of 42 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.9%) to 99.407%

Files with Coverage Reduction New Missed Lines %
src/parser/mod.rs 1 99.64%
Totals Coverage Status
Change from base Build 8204148435: 1.9%
Covered Lines: 1676
Relevant Lines: 1686

💛 - Coveralls

@veeso veeso merged commit 09e3979 into veeso:main Dec 16, 2024
2 checks passed
@veeso
Copy link
Owner

veeso commented Dec 16, 2024

Thank you so much for this pr!

@crazyscot crazyscot deleted the wry/update-ci branch December 16, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - actions-rs/cargo is unmaintained and must be replaced
4 participants