Improve LBM/QML output buffer scroll behavior; Add build instructions #422
+100
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've been running this for a while now with a device spamming prints continously, and there doesn't seem to be any performance issues on my laptop at least. |
Improves the LBM REPL and QMl output buffers in two ways: 1. Makes them only snap to the bottom when the view was already scrolled to the bottom. This makes is far easier to read output when connected to a device which prints stuff often. 2. Changes how the LBM REPL output is trimmed so that maintains the scroll position how you'd expect. The lack of this feature only became apparent after the first change.
laxsjo
force-pushed
the
feat/nicer-scrolling
branch
from
daa7a3e to
cce9994
Compare
Contributor
Author
|
Updated the build instructions with a note about you needing to install the dependencies. I keept it kind of vague since I don't have a debian-based OS to try it on. |
Contributor
Author
|
Oh, just realized that #312 already exists which added some build instructions. But it's instructions were also pretty specific. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the scroll behavior for the LBM REPL and QMl output buffers via two changes:
I also added some build instructions in the README.md. I decided to put the change in this PR since I'm lazy, hope you don't mind (if you do I'm happy to separate it out).
I mainly wanted to add instructions for building VESC Tool with Nix, but I ended up also adding instructions for building it normally on Linux. :)