Skip to content

A workaround for canbus on linux #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

A workaround for canbus on linux #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f362b67
Fool Qt serial into not attempting to set a socketcan bitrate
p0wdrdotcom Dec 7, 2022
3dbd469
enable can in the build
p0wdrdotcom Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vesc_tool.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ ios: {

# CAN bus available
# Adding serialbus to Qt seems to break the serial port on static builds. TODO: Figure out why.
#DEFINES += HAS_CANBUS
DEFINES += HAS_CANBUS

# Positioning
DEFINES += HAS_POS
Expand Down
4 changes: 3 additions & 1 deletion vescinterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2373,7 +2373,9 @@ bool VescInterface::connectCANbus(QString backend, QString ifName, int bitrate)
mCanDevice->setConfigurationParameter(QCanBusDevice::ReceiveOwnKey, false);
// bitrate change not supported yet by socketcan. It is possible to set the rate when
// configuring the CAN network interface using the ip link command.
// mCanDevice->setConfigurationParameter(QCanBusDevice::BitRateKey, bitrate);
// This needs to happen or Qt will try and set a default bitrate which libsocketsocket can doesn't accept
mCanDevice->setConfigurationParameter(QCanBusDevice::BitRateKey, QVariant());

mCanDevice->setConfigurationParameter(QCanBusDevice::CanFdKey, false);
mCanDevice->setConfigurationParameter(QCanBusDevice::ReceiveOwnKey, false);

Expand Down