Skip to content

fix(api): accept verbatim extraction mode in bank manifests#2576

Merged
benfrank241 merged 1 commit into
vectorize-io:mainfrom
ishanmalik:fix/bank-template-verbatim-mode
Jul 7, 2026
Merged

fix(api): accept verbatim extraction mode in bank manifests#2576
benfrank241 merged 1 commit into
vectorize-io:mainfrom
ishanmalik:fix/bank-template-verbatim-mode

Conversation

@ishanmalik

Copy link
Copy Markdown
Contributor

Problem

The engine accepts retain_extraction_mode=verbatim through environment/config resolution, but bank-template manifest import rejected the same mode because the validator had a re-typed mode tuple that omitted it. This surfaced during a verbatim-mode data migration.

Solution

Use the canonical RETAIN_EXTRACTION_MODES tuple for bank-template validation so future extraction modes cannot drift, and update the related API schema descriptions to include verbatim and chunks.

Testing

  • uv run --directory hindsight-api-slim pytest tests/test_bank_templates.py::TestImportValidation::test_verbatim_extraction_mode_is_valid
  • uv run --directory hindsight-api-slim python -m py_compile hindsight_api/api/http.py
  • scripts/generate-bank-template-schema.sh
  • scripts/generate-docs-skill.sh

@ishanmalik

Copy link
Copy Markdown
Contributor Author

Follow-up: re-ran scripts/generate-openapi.sh with full docs dependencies installed — build validates and the regenerated artifacts match the committed ones exactly (no diff). The client-description strings updated manually in this PR are likewise identical to generator output.

@benfrank241

Copy link
Copy Markdown
Member

thanks @ishanmalik good catch.

@benfrank241 benfrank241 merged commit 73d3231 into vectorize-io:main Jul 7, 2026
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants