fix(api): accept verbatim extraction mode in bank manifests#2576
Merged
benfrank241 merged 1 commit intoJul 7, 2026
Merged
Conversation
Contributor
Author
|
Follow-up: re-ran |
Member
|
thanks @ishanmalik good catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The engine accepts
retain_extraction_mode=verbatimthrough environment/config resolution, but bank-template manifest import rejected the same mode because the validator had a re-typed mode tuple that omitted it. This surfaced during a verbatim-mode data migration.Solution
Use the canonical
RETAIN_EXTRACTION_MODEStuple for bank-template validation so future extraction modes cannot drift, and update the related API schema descriptions to includeverbatimandchunks.Testing
uv run --directory hindsight-api-slim pytest tests/test_bank_templates.py::TestImportValidation::test_verbatim_extraction_mode_is_validuv run --directory hindsight-api-slim python -m py_compile hindsight_api/api/http.pyscripts/generate-bank-template-schema.shscripts/generate-docs-skill.sh