Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The retained systemd-units configuration supplies vector.service independently of the removed explicit asset, preserving service packaging while eliminating the duplicate path.
🤖 Bits Code Review · Commit 1642a30
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #26830 upgraded cargo-deb, Debian packages contain
vector.serviceat both/lib/systemd/system/and/usr/lib/systemd/system/: our explicit asset retains the old path while cargo-deb automatically adds the new one. On Debian 13, where/libis a symlink to/usr/lib, upgrading from 0.60.0 fails withunable to open '/usr/lib/systemd/system/vector.service.dpkg-new': No such file or directoryand leaves the service missing.Remove the redundant explicit asset. The existing
systemd-unitsconfiguration packages the service once at/usr/lib/systemd/system/vector.service.References
Follow-up to #26830; related to #26812.
Vector configuration
Service startup and running-service upgrades used:
How did you test this PR?
Tests used the published Vector 0.60.0 executable repackaged as 0.61.0-1 with cargo-deb 3.6.2 and Debian metadata matching this branch. This validates packaging and service lifecycle; a fresh Vector build and other architectures/distributions were not tested. Cargo manifest parsing and diff checks passed.
Does this PR include user facing changes?
no-changeloglabel to this PR.