Repository navigation
Conversation
Chain validation against `ca_file` only proves a client holds some certificate issued by that CA. Add `ClientCertVerifier` and `TlsSettings::with_client_cert_verifier` so servers can restrict which of those certificates they accept. Installing a verifier requires a client certificate and a CA file, and disables session resumption. `TlsAcceptorReloader` keeps the verifier across reloads, and `bind_reloadable` errors when given a reloader while TLS is disabled. Rejected client certificates now surface OpenSSL's verify result as `TlsError::PeerCertificateRejected`. Also fix session resumption on servers that request client certificates, and let the `http_server` source serve a reloadable acceptor.
github-actions
Bot
added
domain:sources
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm still working on polishing this PR, but I'm opening it as a draft for visibility.
Chain validation against
ca_fileonly proves a client holds some certificate issued by that CA. AddClientCertVerifierandTlsSettings::with_client_cert_verifierso servers can restrict which of those certificates they accept. Installing a verifier requires a client certificate and a CA file, and disables session resumption.TlsAcceptorReloaderkeeps the verifier across reloads, andbind_reloadableerrors when given a reloader while TLS is disabled. Rejected client certificates now surface OpenSSL's verify result asTlsError::PeerCertificateRejected.Also fix session resumption on servers that request client certificates, and let the
http_serversource serve a reloadable acceptor.Vector configuration
TODO
How did you test this PR?
TODO
Does this PR include user facing changes?
no-changeloglabel to this PR.