Skip to content

fix(packaging): upgrade cargo-deb to 3.6.2 - #26830

Merged
thomasqueirozb merged 1 commit into
masterfrom
pront-upgrade-cargo-deb-3.6.2
Oct 23, 2026
Merged

thomasqueirozb merged 1 commit into
masterfrom
pront-upgrade-cargo-deb-3.6.2

Conversation

@pront

@pront pront commented Oct 23, 2026

Copy link
Copy Markdown
Member

Summary

Upgrade cargo-deb from 2.9.3 to 3.6.2, the first release containing the upstream fix that adds ./ prefixes to package tar members. This allows unattended-upgrades to find packaged conffiles when checking locally modified or deleted files, avoiding false conffile prompts when the packaged contents are unchanged.

References

Closes #26812.

Upstream fix: kornelski/cargo-deb@d41dbbd

Vector configuration

N/A — packaging-tool version change only.

How did you test this PR?

  • Shell syntax validation and ShellCheck passed for the updated setup script.
  • Inspected the published 0.59.0 and 0.60.0 arm64 packages: both lack ./ prefixes, while /etc/default/vector has identical contents. Verified that cargo-deb 3.6.2 contains the upstream fix and 3.6.1 does not.
  • Package builds and end-to-end unattended-upgrade validation were not run; the local Docker daemon is unavailable.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

@pront
pront requested a review from a team as a code owner October 23, 2026 20:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-23T20:27:47.842116Z f06c606 PR opened
🔒 Security Review ✅ Completed 2026-10-23T20:31:18.590281Z f06c606 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The completed static review raised no actionable issue with the cargo-deb upgrade. Its intended conffile behavior remains unverified through package builds or an end-to-end unattended-upgrade run.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit f06c606

@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 23, 2026
@thomasqueirozb
thomasqueirozb added this pull request to the merge queue Oct 23, 2026
Merged via the queue into master with commit bdd8842 Oct 23, 2026
109 of 110 checks passed
@thomasqueirozb
thomasqueirozb deleted the pront-upgrade-cargo-deb-3.6.2 branch October 23, 2026 21:38
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 23, 2026
@pront

pront commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

Hmm, I found one concrete packaging change that we should address in a follow up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.deb packages store data members without the "./" prefix, which breaks Debian unattended-upgrades' conffile check (Vector never auto-upgrades)

2 participants