Repository navigation
chore(internal_events): remove blanket dead_code allows from remaining internal events - #26806
Merged
Merged
Conversation
…g internal events
JinchengCao
added
the
no-changelog
JinchengCao
marked this pull request as ready for review
October 23, 2026 16:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadoghq-integration[bot]](https://avatars.githubusercontent.com/u/16866914?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The static reviewer found the feature gates consistent with existing callers and Cargo dependencies, with no actionable regressions. No human PR discussion added concerns or qualifications.
🤖 Bits Code Review · Commit e7b8f20
pront
approved these changes
Oct 23, 2026
thomasqueirozb
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the module-wide
allow(dead_code)from the remaining internal events modules (aws_sqs,http_client_source,parser,prometheus,unix) by gating each event on the features that use it. Event implementations are unchanged. Inparser.rs, the unusedRETAIN_EVENTconstant is removed, and the redundantallow(dead_code)onDROP_EVENTis dropped since every feature that compiles the module uses it.SqsMessageReceiveSucceeded,SqsMessageProcessingSucceeded,SqsS3EventRecordInvalidEventIgnoredmod s3:sources-aws_s3HttpClientEventsReceivedsources::util::http_clientandsources::okta::clientsources-http_client,sources-prometheus_scrapeorsources-okta(same gate assources::util::http_client)ParserMatchError,ParserConversionError,truncate_string_atmod kubernetes_logs:sources-kubernetes_logsPrometheusRemoteWriteParseErrorsources-prometheus_remote_writeUnixSocketFileDeleteErrorsources-utils-net-unix,sources-socketorsources-dnstapReferences
Related: #23659
Vector configuration
NA
How did you test this PR?
cargo hack check --each-featurepass with no warnings for each feature that compiles these modules, and with no features.make check-fmtpass.Does this PR include user facing changes?