Skip to content

chore(sematext sink): migrate sematext metrics sink to the native Hyper 1 client - #26752

Merged
thomasqueirozb merged 1 commit into
masterfrom
http-1-sematext-metrics
Oct 20, 2026
Merged

thomasqueirozb merged 1 commit into
masterfrom
http-1-sematext-metrics

Conversation

@thomasqueirozb

Copy link
Copy Markdown
Member

Summary

Migrates the sematext_metrics sink from HttpBatchService to the native Hyper 1 http_v1::HttpService, following #26351 and #26749.

http_v1::HttpService gains opt-in response decompression (with_response_decompression, via tower-http 0.6) so this sink keeps the legacy batch service's compressed-response behavior; other native HTTP 1 sinks keep requesting identity encoding.

References

Vector configuration

NA

How did you test this PR?

  • Unit tests for response decompression in sinks::util::http_v1
  • sinks::sematext unit tests

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 20, 2026
@github-actions github-actions Bot added the domain: sinks Anything related to Vector's sinks label Oct 20, 2026
@thomasqueirozb
thomasqueirozb marked this pull request as ready for review October 20, 2026 19:19
@thomasqueirozb
thomasqueirozb requested a review from a team as a code owner October 20, 2026 19:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T19:22:35.889616Z 0fdd03b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Sematext retains compressed-response decoding and status-based retries through the new HTTP service. Runtime validation was blocked by the pinned Rust toolchain download failure.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 0fdd03b

@thomasqueirozb
thomasqueirozb added this pull request to stack #26755 October 20, 2026 19:25
@thomasqueirozb
thomasqueirozb added this pull request to the merge queue Oct 20, 2026
Merged via the queue into master with commit 5762f67 Oct 20, 2026
109 of 110 checks passed
@thomasqueirozb
thomasqueirozb deleted the http-1-sematext-metrics branch October 20, 2026 20:18
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: sinks Anything related to Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants