Repository navigation
enhancement(core): Omit default schema definition from event metadata - #26744
Merged
Merged
Conversation
Store `schema_definition` as an `Option`, with `None` standing for the shared default built in `DEFAULT_SCHEMA_DEFINITION`. Creating metadata no longer allocates for the schema, and the default path touches no reference count, so it adds no shared counter for threads to contend on. `schema_definition()` still returns the same value, equality treats `None` and an equal explicit definition as the same, and `add_schema_meaning` still copies on write.
bruceg
added
domain: logs
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadoghq-integration[bot]](https://avatars.githubusercontent.com/u/16866914?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The implicit default remains equivalent to an explicit default schema, and adding schema meanings preserves copy-on-write isolation. The completed specialist review identified no actionable regressions.
🤖 Bits Code Review · Commit 785480c
gwenaskell
approved these changes
Oct 20, 2026
pront
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store
schema_definitionas anOption, withNonestanding for the shared default built inDEFAULT_SCHEMA_DEFINITION. Creating metadata no longer allocates for the schema, and the default path touches no reference count, so it adds no shared counter for threads to contend on.schema_definition()still returns the same value, equality treatsNoneand an equal explicit definition as the same, andadd_schema_meaningstill copies on write.References
Vector configuration
How did you test this PR?
Does this PR include user facing changes?
no-changeloglabel to this PR.Contributor Guidelines
@vectordotdev/vectorto reach out to us regarding this PR.git merge origin masterandgit push.