Skip to content

chore(ci): allow OP team members to trigger integration & e2e tests - #26589

Merged
tessneau merged 3 commits into
masterfrom
tess.neau/ci-review-same-repo
Oct 8, 2026
Merged

chore(ci): allow OP team members to trigger integration & e2e tests#26589
tessneau merged 3 commits into
masterfrom
tess.neau/ci-review-same-repo

Conversation

@tessneau

@tessneau tessneau commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Allows OP team members to run integration and e2e CI review commands alongside Vector team members.

Initially I went with adding this ability for non-fork branches but this ended up being a lot simpler than those conditions.

References

Motivated by #26554.

Vector configuration

N/A

How did you test this PR?

Left a review comment with /ci-run-e2e-opentelemetry-traces and e2e test CI ran as expected: https://github.com/vectordotdev/vector/actions/runs/37781195933/job/113325258316?pr=26589

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Before pushing, follow our pre-push guidance.
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.

@github-actions github-actions Bot added the domain: ci Anything related to Vector's CI environment label Oct 8, 2026
@tessneau tessneau changed the title Allow integration CI review commands on same-repository PRs chore(ci): allow integration review commands on same-repository PRs Oct 8, 2026
tessneau
tessneau commented Oct 8, 2026
View reviewed changes

@tessneau tessneau left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-e2e-opentelemetry-traces

@tessneau tessneau added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 8, 2026
@tessneau
tessneau marked this pull request as ready for review October 8, 2026 12:34
@tessneau
tessneau requested a review from a team as a code owner October 8, 2026 12:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T12:37:04.590810Z 60419c0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Oct 8, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60419c0e26

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci-integration-review.yml Outdated
datadoghq-integration[bot]
datadoghq-integration Bot reviewed Oct 8, 2026
View reviewed changes

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The authorization condition allows same-repository PRs as intended while retaining the Vector-team restriction for fork PRs. Hosted GitHub Actions execution remains unverified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 60419c0 · @DataDog review to ask questions

@tessneau tessneau changed the title chore(ci): allow integration review commands on same-repository PRs chore(ci): allow PR authors to trigger integration tests on same-repository branches Oct 8, 2026
tessneau
tessneau commented Oct 8, 2026
View reviewed changes

@tessneau tessneau left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-e2e-opentelemetry-traces

@tessneau tessneau changed the title chore(ci): allow PR authors to trigger integration tests on same-repository branches chore(ci): allow OP team members to trigger integration tests Oct 8, 2026
tessneau
tessneau commented Oct 8, 2026
View reviewed changes

@tessneau tessneau left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-e2e-opentelemetry-traces

@tessneau tessneau changed the title chore(ci): allow OP team members to trigger integration tests chore(ci): allow OP team members to trigger integration & e2e tests Oct 8, 2026
@tessneau
tessneau requested a review from bruceg October 8, 2026 13:18
@tessneau
tessneau added this pull request to the merge queue Oct 8, 2026
Merged via the queue into master with commit 3f6d144 Oct 8, 2026
177 checks passed
@tessneau
tessneau deleted the tess.neau/ci-review-same-repo branch October 8, 2026 15:38
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@datadoghq-integration datadoghq-integration[bot] datadoghq-integration[bot] left review comments
@pront pront pront approved these changes
@gwenaskell gwenaskell gwenaskell approved these changes
@bruceg bruceg Awaiting requested review from bruceg

Assignees

No one assigned

Labels

domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tessneau @pront @gwenaskell