Skip to content

Commit

Permalink
fix: tsconfig should reflect either composite or declaration wh…
Browse files Browse the repository at this point in the history
…en `declarationMap` is `true` (#1351)

* fix: tsconfig should reflect either composite or declaration

* fix: abi constructor should be protected
  • Loading branch information
freemanzMrojo authored Sep 26, 2024
1 parent b09bbfb commit 1955abc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/core/src/vcdm/abi/ABI.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class ABI implements VeChainDataModel<ABI> {
* @param {string | AbiParameter[]} types - A list of ABI types representing the types of the values.
* @param {unknown[]} values - An array of values according to the specified ABI types.
**/
public constructor(
protected constructor(
types: string | AbiParameter[] = [],
values: unknown[] = []
) {
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"display": "Default",
"compilerOptions": {
"composite": false,
"declaration": false,
"declaration": true,
"declarationMap": true,
"esModuleInterop": true,
"module": "ESNext",
Expand Down

1 comment on commit 1955abc

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 97%
97.8% (4184/4278) 95.83% (1359/1418) 97.05% (856/882)
Title Tests Skipped Failures Errors Time
core 764 0 💤 0 ❌ 0 🔥 1m 55s ⏱️
network 692 0 💤 0 ❌ 0 🔥 4m 41s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 17.862s ⏱️

Please sign in to comment.