Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage #28

Merged
merged 14 commits into from
Nov 19, 2024
Merged

Fix coverage #28

merged 14 commits into from
Nov 19, 2024

Conversation

roisindowling
Copy link
Contributor

No description provided.

Copy link

socket-security bot commented Nov 19, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 97.74011% with 16 lines in your changes missing coverage. Please review.

Project coverage is 93.90%. Comparing base (d19599e) to head (cff785d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
contracts/GalaxyMember.sol 95.74% 6 Missing ⚠️
...s/x-2-earn-apps/modules/EndorsementUpgradeable.sol 97.63% 3 Missing ⚠️
contracts/VoterRewards.sol 93.93% 2 Missing ⚠️
contracts/X2EarnApps.sol 95.23% 2 Missing ⚠️
contracts/X2EarnCreator.sol 96.07% 2 Missing ⚠️
...ts/x-2-earn-apps/libraries/AdministrationUtils.sol 98.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   96.79%   93.90%   -2.90%     
==========================================
  Files          48       55       +7     
  Lines        3437     3463      +26     
  Branches      474      774     +300     
==========================================
- Hits         3327     3252      -75     
- Misses        109      211     +102     
+ Partials        1        0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Report too large to display inline

View full report↗︎

@roisindowling roisindowling changed the base branch from main to endors November 19, 2024 09:04
@roisindowling roisindowling changed the title Test Fix coverage Nov 19, 2024
@roisindowling roisindowling marked this pull request as ready for review November 19, 2024 09:05
@roisindowling roisindowling requested a review from a team as a code owner November 19, 2024 09:05
@roisindowling roisindowling merged commit 5cef217 into endors Nov 19, 2024
8 checks passed
@roisindowling roisindowling deleted the test branch November 19, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants