Skip to content

Commit

Permalink
sagemathgh-36715: build/bin/sage-logger [V=0]: Show more lines of the…
Browse files Browse the repository at this point in the history
… log of failing builds

When using `make V=0`, we build packages silently, and on errors we
print out the tail of the log. For example, in
https://github.com/sagemath/sage/actions/runs/6842945144/job/18611620859
#step:11:7349
```
  [sphinxcontrib_serializinghtml-1.1.5] error installing, exit status 1.
End of log file:
  [sphinxcontrib_serializinghtml-1.1.5]     │ exit code: 1
  [sphinxcontrib_serializinghtml-1.1.5]     ╰─> See above for output.
  [sphinxcontrib_serializinghtml-1.1.5]
  [sphinxcontrib_serializinghtml-1.1.5]     note: This error originates
from a subprocess, and is likely not a problem with pip.
  [sphinxcontrib_serializinghtml-1.1.5]     full command:
/sage/local/var/lib/sage/venv-python3.9/bin/python3 -c '
  [sphinxcontrib_serializinghtml-1.1.5]     exec(compile('"'"''"'"''"'"'
```
But as this example shows, the current setting of showing 72 lines is no
longer suitable for Python packages. It only shows lengthy output from a
setuptools wrapper and boilerplate apologies from pip.

The real error message appears earlier, as can be seen in the full
printout of the log: https://github.com/sagemath/sage/actions/runs/68429
45144/job/18611620859#step:14:8095

Here we increase it from 72 lines to 120 lines, which should still be OK
for output on the terminal.

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

URL: sagemath#36715
Reported by: Matthias Köppe
Reviewer(s): John H. Palmieri
  • Loading branch information
Release Manager committed Dec 7, 2023
2 parents 3c55fac + 70137ce commit c3eda60
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion build/bin/sage-logger
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ if [ -n "$SAGE_SILENT_BUILD" -a ${use_prefix} = true ]; then
status=$?
if [[ $status != 0 ]]; then
echo " [$logname] error installing, exit status $status. End of log file:"
tail -n 72 "$logfile" | sed "/Please email sage-devel/,$ d;s;^; [$logname] ;" >&2
tail -n 120 "$logfile" | sed "/Please email sage-devel/,$ d;s;^; [$logname] ;" >&2
echo " [$logname] Full log file: $logfile"
else
echo " [$logname] successfully installed."
Expand Down
6 changes: 3 additions & 3 deletions build/pkgs/configure/checksums.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tarball=configure-VERSION.tar.gz
sha1=cba1a107f45084e1884ca8a873504c70eec9c16c
md5=b61e77023581c8994c73313e867a6c26
cksum=615928275
sha1=fb45063d063bdedef5f2b023360a578d94e02d7d
md5=b5c59c2eafc8866fd13883c13fcf170e
cksum=2176047918
2 changes: 1 addition & 1 deletion build/pkgs/configure/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
9b1e18ffc022a8ed0e7451ccf190a009ceb2d81c
ef737ec1e85ef493cf23c4fbf7bd18fcf841a26c

0 comments on commit c3eda60

Please sign in to comment.