Skip to content

Commit

Permalink
sagemathgh-39074: Fix the issue number format in deprecation comment
Browse files Browse the repository at this point in the history
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes a typo in the developer guide, noted in
sagemath#38207 (comment).

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#39074
Reported by: Kwankyu Lee
Reviewer(s): Frédéric Chapoton
  • Loading branch information
Release Manager committed Dec 6, 2024
2 parents 7739f4f + 2e7e215 commit 28dcbf5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions build/pkgs/configure/checksums.ini
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
tarball=configure-VERSION.tar.gz
sha1=62eedaff4c03b55fdd6f8e1242026226adbf3a16
sha256=54036d6435218ce1daa7d5d512e1bfd74d3713ed5745d5c49ee1f5e6122a25de
sha1=281536743d90c17bd35976ebdfb41dd37ddf70fe
sha256=765ef990d39e231579c0423441d77cb37c3a436fc55f307e963ff3983124d3a7
2 changes: 1 addition & 1 deletion build/pkgs/configure/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
f6ad0ecf1f4a269f5954d5487336b13f70624594
0fdf86888a3a1d03d9e7785ee10521ceb0d48faf
4 changes: 2 additions & 2 deletions src/doc/en/developer/coding_in_python.rst
Original file line number Diff line number Diff line change
Expand Up @@ -786,13 +786,13 @@ the procedure below:
class NewClass:
...
OldClass = NewClass # OldClass is deprecated. See Issue 12345.
OldClass = NewClass # OldClass is deprecated. See Issue #12345.
* **Removing a class:** add a comment:

.. CODE-BLOCK:: python
# OldClass is deprecated. See Issue 12345.
# OldClass is deprecated. See Issue #12345.
class OldClass:
Expand Down

0 comments on commit 28dcbf5

Please sign in to comment.