-
Notifications
You must be signed in to change notification settings - Fork 7.5k
fix: breadcrumb style is affected by the globally-imported antd styles #5627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe changes update the styling of the breadcrumb component in the Vue UI kit. The modifications introduce the additional class Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/@core/ui-kit/shadcn-ui/src/components/breadcrumb/breadcrumb-view.vue (1)
31-39
: Good use of scoped styles to fix Antd styling conflicts.The implementation correctly uses scoped styles with
:deep()
selectors to target nestedol
andul
elements, effectively fixing the margin issues caused by globally imported Antd styles without affecting other components.Consider adding an English translation alongside the Chinese comment for better international developer experience:
- /** 修复全局引入Antd时,ol和ul的默认样式会被修改的问题 */ + /** + * 修复全局引入Antd时,ol和ul的默认样式会被修改的问题 + * Fixes the issue where default styles of ol and ul are modified when Antd is globally imported + */
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/@core/ui-kit/shadcn-ui/src/components/breadcrumb/breadcrumb-view.vue
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Test (windows-latest)
- GitHub Check: Check (windows-latest)
- GitHub Check: Lint (windows-latest)
- GitHub Check: Check (ubuntu-latest)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Lint (ubuntu-latest)
- GitHub Check: post-update (windows-latest)
- GitHub Check: post-update (ubuntu-latest)
🔇 Additional comments (1)
packages/@core/ui-kit/shadcn-ui/src/components/breadcrumb/breadcrumb-view.vue (1)
23-23
: Clean implementation of targeted class addition.Adding the "vben-breadcrumb" class to both breadcrumb components provides a clear, targeted way to apply specific styles to override the Antd global styles.
Also applies to: 28-28
vbenjs#5627) * 修复全局引入Antd时,面包屑的样式会受到影响的问题
Description
修复全局引入Antd时,面包屑的样式会受到影响的问题
fix: #5607
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit
Style
Bug Fixes