Skip to content

fix: breadcrumb style is affected by the globally-imported antd styles #5627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

mynetfan
Copy link
Collaborator

@mynetfan mynetfan commented Feb 27, 2025

Description

修复全局引入Antd时,面包屑的样式会受到影响的问题

fix: #5607

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Style

    • Enhanced the appearance of breadcrumb navigation by applying new styling adjustments. These improvements include refined spacing for ordered and unordered list elements, ensuring consistent alignment and a modern, streamlined interface.
  • Bug Fixes

    • Resolved an issue with unexpected margins caused by external design frameworks. The updated styles now ensure breadcrumb list elements display uniformly without extra spacing, delivering a more cohesive and polished user experience.

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: d41ee27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Feb 27, 2025

Walkthrough

The changes update the styling of the breadcrumb component in the Vue UI kit. The modifications introduce the additional class vben-breadcrumb to both the Breadcrumb and BreadcrumbBackground components in the breadcrumb-view.vue file. A new scoped style block is also added to explicitly set margin-bottom: 0 for ol and ul elements, addressing conflicts with Ant Design’s global styles. No alterations were made to exported or public entities.

Changes

File Change Summary
packages/@core/ui-kit/.../components/breadcrumb/breadcrumb-view.vue Added the vben-breadcrumb class to both Breadcrumb and BreadcrumbBackground; introduced a scoped style section to set margin-bottom: 0 for ol/ul.

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • anncwb
  • vince292007

Poem

I'm a little rabbit, hopping through code,
Breadcrumbs now sparkle on every node.
With a new style kiss and a CSS embrace,
I leave no margin's trace in this place.
Hop along and let the changes delight—
A hoppy commit shines ever so bright!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/@core/ui-kit/shadcn-ui/src/components/breadcrumb/breadcrumb-view.vue (1)

31-39: Good use of scoped styles to fix Antd styling conflicts.

The implementation correctly uses scoped styles with :deep() selectors to target nested ol and ul elements, effectively fixing the margin issues caused by globally imported Antd styles without affecting other components.

Consider adding an English translation alongside the Chinese comment for better international developer experience:

- /** 修复全局引入Antd时,ol和ul的默认样式会被修改的问题 */
+ /** 
+  * 修复全局引入Antd时,ol和ul的默认样式会被修改的问题
+  * Fixes the issue where default styles of ol and ul are modified when Antd is globally imported
+  */
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86ce65e and d41ee27.

📒 Files selected for processing (1)
  • packages/@core/ui-kit/shadcn-ui/src/components/breadcrumb/breadcrumb-view.vue (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Test (windows-latest)
  • GitHub Check: Check (windows-latest)
  • GitHub Check: Lint (windows-latest)
  • GitHub Check: Check (ubuntu-latest)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Lint (ubuntu-latest)
  • GitHub Check: post-update (windows-latest)
  • GitHub Check: post-update (ubuntu-latest)
🔇 Additional comments (1)
packages/@core/ui-kit/shadcn-ui/src/components/breadcrumb/breadcrumb-view.vue (1)

23-23: Clean implementation of targeted class addition.

Adding the "vben-breadcrumb" class to both breadcrumb components provides a clear, targeted way to apply specific styles to override the Antd global styles.

Also applies to: 28-28

@mynetfan mynetfan merged commit 0e0661f into vbenjs:main Feb 27, 2025
14 checks passed
@mynetfan mynetfan deleted the fix/antd-global-import branch February 27, 2025 14:29
zmlo1 pushed a commit to zmlo1/cz-admin-vben that referenced this pull request Mar 21, 2025
vbenjs#5627)

* 修复全局引入Antd时,面包屑的样式会受到影响的问题
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: antv模块中使用全局完整注册后,顶部面包屑导航样式错位
1 participant