fix: mouse events ignored on modal loading

[mynetfan]

Description

修复Modal在Loading状态时，鼠标仍然可以选中遮罩层后面文字的问题

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• Bug Fixes
  • Updated modal component to allow pointer events during loading or submitting states
  • Improved API component prop binding to support dynamic model property names
  • Simplified API component template structure by removing unnecessary wrapper div

[changeset-bot]

⚠️ No Changeset found

Latest commit: be37752

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/@core/ui-kit/popup-ui/src/modal/modal.vue

Oops! Something went wrong! :(

ESLint: 9.17.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

Walkthrough

The pull request involves modifications to two Vue components: modal.vue and api-component.vue. In the modal component, the class binding for a div element is simplified by removing the pointer-events-none class. The api-component.vue sees changes in its bindProps computed property to dynamically handle model update events and a template restructuring that removes an outer div wrapper around the component.

Changes

File	Change Summary
packages/@core/ui-kit/popup-ui/src/modal/modal.vue	Removed pointer-events-none class from div element
packages/effects/common-ui/src/components/api-component/api-component.vue	Updated bindProps to use dynamic model prop name and removed outer div wrapper

Possibly related PRs

• perf: modal and drawer api support chain calls #5351: Enhances modal API with method chaining capabilities
• feat: modal state locked on submitting #5401: Introduces submitting property and lock method for modal interactions

Suggested reviewers

• anncwb
• vince292007

Poem

🐰 A modal's dance, a class stripped bare,
Components twirl with newfound flair
Pointer events now free to roam
In CodeRabbit's UI, they find their home!
Simplicity hops, code leaps with glee 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 509b268 and be37752.

📒 Files selected for processing (2)

• packages/@core/ui-kit/popup-ui/src/modal/modal.vue (1 hunks)
• packages/effects/common-ui/src/components/api-component/api-component.vue (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: Lint (windows-latest)
• GitHub Check: Test (windows-latest)
• GitHub Check: Check (windows-latest)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: Test (ubuntu-latest)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: post-update (windows-latest)
• GitHub Check: post-update (ubuntu-latest)

🔇 Additional comments (3)

packages/effects/common-ui/src/components/api-component/api-component.vue (2)

124-124: LGTM! Good practice to prevent duplicate event handlers.

The use of objectOmit to remove any existing model update event handler from attrs prevents potential conflicts with the component's own handler.

---

194-205: LGTM! Template structure simplified.

The removal of the outer div wrapper simplifies the template structure without affecting functionality, as the component itself provides the necessary structure.

packages/@core/ui-kit/popup-ui/src/modal/modal.vue (1)

255-255: LGTM! This fixes the modal loading interaction issue.

Removing the pointer-events-none class while keeping overflow-hidden is the correct approach. This ensures that:

1. Mouse events are properly captured by the modal during loading/submitting states
2. Users cannot interact with content behind the modal overlay
3. The content remains non-scrollable during loading states

This change directly addresses the PR objective of fixing mouse events being ignored during modal loading.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.