fix: 修复avatar alt传空bug Bug: 头像插件有返回alt为空的时候，是否删除代码 #5295

[clddup]

Description

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• Bug Fixes
  • Improved avatar component stability by adding null-safe handling for alternative text
  • Prevented potential runtime errors when avatar alternative text is undefined
• New Features
  • Enhanced visibility of the chartInstance variable in the useEcharts function for better accessibility.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c333cbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/effects/plugins/src/echarts/use-echarts.ts

Oops! Something went wrong! :(

ESLint: 9.17.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

Walkthrough

The pull request modifies the avatar.vue component in the UI kit, specifically improving the robustness of the text computed property. The change introduces optional chaining to the props.alt property, preventing potential runtime errors when alt is undefined or null. This enhancement ensures that the component can handle cases where the alternative text might be missing without throwing an error. Additionally, the useEcharts function in the use-echarts.ts file has been updated to include the chartInstance in its return statement, improving its accessibility.

Changes

File	Change Summary
packages/@core/ui-kit/shadcn-ui/src/components/avatar/avatar.vue	Added optional chaining to props.alt in the text computed property to handle undefined or null values gracefully.
packages/effects/plugins/src/echarts/use-echarts.ts	Updated the return value of useEcharts to include chartInstance for improved accessibility.

Possibly related issues

• vbenjs/vue-vben-admin#5295: Directly addresses the issue of potential exceptions when alt is empty, providing a robust solution through optional chaining.

Possibly related PRs

• feat: useEcharts exports echarts instance #5294 #5299: The changes in this PR involve modifications to the useEcharts function in the same file as the main PR, specifically enhancing the return value to include the chartInstance, which is relevant to the overall functionality of the component.

Suggested reviewers

• mynetfan
• vince292007
• anncwb

Poem

🐰 A Rabbit's Ode to Robust Code 🐰
In the realm of Vue, where components play,
Optional chaining saves the day!
No more errors when alt goes astray,
Our avatar smiles, come what may!
Graceful handling, code's ballet 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c28c119 and c333cbe.

📒 Files selected for processing (1)

• packages/effects/plugins/src/echarts/use-echarts.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: Test (windows-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: Test (ubuntu-latest)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: post-update (windows-latest)
• GitHub Check: Check (windows-latest)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: post-update (ubuntu-latest)

🔇 Additional comments (1)

packages/effects/plugins/src/echarts/use-echarts.ts (1)

112-112: Great addition for external manipulations.

Exposing chartInstance in the return object increases flexibility, allowing direct chart manipulations outside the composable. Make sure consumers of this function handle the chart instance carefully (e.g., verifying if it’s already disposed before re-initializing, avoiding concurrency conflicts, etc.).

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.