Skip to content

Add clip path and viewBox default property #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add clip path and viewBox default property #88

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b5d290
add clippath
mgufrone Nov 10, 2017
6f7b2c7
fix closing tag
mgufrone Nov 10, 2017
a13713f
supress error of parsing xml
mgufrone Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import resolveAssetSource from 'react-native/Libraries/Image/resolveAssetSource'
import Svg,{
Circle,
Ellipse,
ClipPath,
G ,
LinearGradient,
RadialGradient,
Expand All @@ -26,6 +27,7 @@ import * as utils from './utils';
const ACCEPTED_SVG_ELEMENTS = [
'svg',
'g',
'clipPath',
'circle',
'path',
'rect',
Expand All @@ -44,6 +46,7 @@ const ACCEPTED_SVG_ELEMENTS = [
// Attributes from SVG elements that are mapped directly.
const SVG_ATTS = ['viewBox', 'width', 'height'];
const G_ATTS = ['id'];
const CLIP_PATH_ATTS = ['id'];

const CIRCLE_ATTS = ['cx', 'cy', 'r'];
const PATH_ATTS = ['d'];
Expand Down Expand Up @@ -158,6 +161,9 @@ class SvgUri extends Component{
switch (node.nodeName) {
case 'svg':
componentAtts = this.obtainComponentAtts(node, SVG_ATTS);
if (!componentAtts.viewBox) {
componentAtts.viewBox = `0 0 ${componentAtts.width} ${componentAtts.height}`;
}
if (this.props.width) {
componentAtts.width = this.props.width;
}
Expand All @@ -169,6 +175,9 @@ class SvgUri extends Component{
case 'g':
componentAtts = this.obtainComponentAtts(node, G_ATTS);
return <G key={i} {...componentAtts}>{childs}</G>;
case 'clipPath':
componentAtts = this.obtainComponentAtts(node, CLIP_PATH_ATTS);
return <ClipPath key={i} {...componentAtts}>{childs}</ClipPath>;
case 'path':
componentAtts = this.obtainComponentAtts(node, PATH_ATTS);
return <Path key={i} {...componentAtts}>{childs}</Path>;
Expand Down Expand Up @@ -290,7 +299,7 @@ class SvgUri extends Component{
</View>
);
} catch(e){
console.error("ERROR SVG", e);
console.log("ERROR SVG", e);
return null;
}
}
Expand Down