Skip to content

--enh Adding support for use tag #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

--enh Adding support for use tag #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import Svg,{
Text,
TSpan,
Defs,
Use,
Stop
} from 'react-native-svg';

Expand All @@ -30,6 +31,7 @@ const ACCEPTED_SVG_ELEMENTS = [
'path',
'rect',
'defs',
'use',
'line',
'linearGradient',
'radialGradient',
Expand Down Expand Up @@ -59,12 +61,25 @@ const TEXT_ATTS = ['fontFamily', 'fontSize', 'fontWeight', 'textAnchor']
const POLYGON_ATTS = ['points'];
const POLYLINE_ATTS = ['points'];

const COMMON_ATTS = ['fill', 'fillOpacity', 'stroke', 'strokeWidth', 'strokeOpacity', 'opacity',
const USE_ATTS = ['href'];

const COMMON_ATTS = ['id', 'fill', 'fillOpacity', 'stroke', 'strokeWidth', 'strokeOpacity', 'opacity',
'strokeLinecap', 'strokeLinejoin',
'strokeDasharray', 'strokeDashoffset', 'x', 'y', 'rotate', 'scale', 'origin', 'originX', 'originY', 'transform', 'clipPath'];

let ind = 0;

// https://developer.mozilla.org/en-US/docs/Web/SVG/Element/use#Attributes
function fixXlinkHref (node) {
if (node.attributes) {
const hrefAttr = Object.keys(node.attributes).find(a => node.attributes[a].name === 'href');
const legacyHrefAttr = Object.keys(node.attributes).find(a => node.attributes[a].name === 'xlink:href');

return node.attributes[hrefAttr || legacyHrefAttr].value;
}
return null;
}

function fixYPosition (y, node) {
if (node.attributes) {
const fontSizeAttr = Object.keys(node.attributes).find(a => node.attributes[a].name === 'font-size');
Expand Down Expand Up @@ -189,6 +204,10 @@ class SvgUri extends Component{
return <Line key={i} {...componentAtts}>{childs}</Line>;
case 'defs':
return <Defs key={i}>{childs}</Defs>;
case 'use':
componentAtts = this.obtainComponentAtts(node, USE_ATTS);
componentAtts.href = fixXlinkHref(node);
return <Use key={i} {...componentAtts}/>;
case 'linearGradient':
componentAtts = this.obtainComponentAtts(node, LINEARG_ATTS);
return <LinearGradient key={i} {...componentAtts}>{childs}</LinearGradient>;
Expand Down Expand Up @@ -252,7 +271,7 @@ class SvgUri extends Component{
inspectNode(node){
// Only process accepted elements
if (!ACCEPTED_SVG_ELEMENTS.includes(node.nodeName)) {
return (<View />);
return (<View key={ind++} />);
}

// Process the xml node
Expand Down