Skip to content

Conversation

ethanyou725
Copy link

No description provided.

Copy link

@fniwes fniwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of cosmetics changes to be sure that the only change you did is to add the missing parenthesis.

Unfortunately, the method trimElementChildren (where is the trim without parenthesis) is broken. This patch will not fix the issue.

There are other pull request that tackle the issue in others ways.

Please refer to pull request #113 or my own pull request #142.

Unfortunately this project seems to be no longer maintained.

@ethanyou725
Copy link
Author

The method trimElementChildren (where is the trim without parenthesis) do not make Text show correct, with add transform to COMMON_ATTS make things right. This project seems to be no longer maintained, so I have to hack this project to our company private npm. 😂

@nesc58
Copy link
Contributor

nesc58 commented Sep 10, 2018

Also fixed in #100
This repo seems really dead

@ethanyou725
Copy link
Author

I fork this repository and add some pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants