Skip to content

Some corrections and code refactoring #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Some corrections and code refactoring #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1547fc2
using Support classes #75 pull request made by @Bernd Schrooten
rcacheira Mar 2, 2018
b581b25
using "Add clip path and viewBox default property #88" pull request m…
rcacheira Mar 2, 2018
d8502fe
Just single reviews. Added a first approach to change fill atts from …
rcacheira Mar 2, 2018
b38599a
Update README.md
rcacheira Mar 2, 2018
7004d98
very beggining of the code refactor
rcacheira Mar 2, 2018
a51d5d5
seriously code refactoring
rcacheira Mar 4, 2018
ac5d7dc
remove yarn-error.log
rcacheira Mar 4, 2018
e335eea
correction to error returning null when a taghandler is found
rcacheira Mar 4, 2018
9782c8b
removed unused code
rcacheira Mar 6, 2018
589ed5f
1.3.0
rcacheira Mar 7, 2018
d0939a8
Correction to fill problem setting fill to undefined when no fill is …
rcacheira Mar 7, 2018
cc1b634
corrected styles selector
rcacheira Mar 8, 2018
fc2501b
1.3.1
rcacheira Mar 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# react-native-svg-uri
This package will finished as a pull request to the package ault-development/react-native-svg-uri but while not feel free to make pull requests
Render SVG images in React Native from an URL or a static file

This was tested with RN 0.33 and react-native-svg 4.3.1 (depends on this library)
Expand Down Expand Up @@ -27,6 +28,7 @@ react-native link react-native-svg # not react-native-svg-uri !!!
| `source` | `ImageSource` | | Same kind of `source` prop that `<Image />` component has
| `svgXmlData` | `String` | | You can pass the SVG as String directly
| `fill` | `Color` | | Overrides all fill attributes of the svg file
| `classes` | `Object` | | Overrides attributes of classes (only overrides those attributes present in the given object)

## Known Bugs

Expand Down Expand Up @@ -64,4 +66,4 @@ This will render:

## Testing
1. Make sure you have installed dependencies with `npm i`
2. Run tests with `npm test`
2. Run tests with `npm test`
Loading