Skip to content

Handle post_multiple returning zero successful updates. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
varyonic merged 1 commit into from
Oct 10, 2025
Merged

Handle post_multiple returning zero successful updates. #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/pocus/resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ def post
def post_multiple(request_path, klass, fields_multiple)
data = fields_multiple.map { |fields| camelize_fields(fields) }
response = session.send_request('POST', path + request_path, data)
resources = response.fetch(klass.tag_multiple).map { |fields| klass.new(fields.merge(parent: self)) }
data = response.fetch(klass.tag_multiple) || []
resources = data.map { |fields| klass.new(fields.merge(parent: self)) }
ResponseArray.new(resources, response['errors'], response['warnings'])
end

Expand Down
9 changes: 9 additions & 0 deletions spec/lib/pocus/contact_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@
expect(contact).to be_kind_of(Pocus::Contact)
expect(contact.contact_id).to match(/^\d+$/)
end

it 'handles error on all contacts' do
fields_multiple = [''].map do |i|
contact_attributes.dup.merge(email: "#{i}@dummy.com")
end
response = test_folder.contacts.create(fields_multiple)
expect(response.warnings.count).to be >= 1
expect(response.first).to eq(nil)
end
end

describe '#reload' do
Expand Down