Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tests #2

Merged
merged 10 commits into from
Aug 19, 2024
Merged

Fix Tests #2

merged 10 commits into from
Aug 19, 2024

Conversation

fpseverino
Copy link
Member

@fpseverino fpseverino commented Aug 16, 2024

  • Fix testing and CI
  • Small refactor with no breaking changes
  • Bump minimum Swift version to 5.8
  • Remove all CocoaPods and useless files

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 98.95833% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@1d63e04). Learn more about missing BASE report.

Files Patch % Lines
Zip/Zip.swift 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   95.90%           
=======================================
  Files           ?        6           
  Lines           ?      366           
  Branches        ?        0           
=======================================
  Hits            ?      351           
  Misses          ?       15           
  Partials        ?        0           
Files Coverage Δ
Zip/ArchiveFile.swift 100.00% <100.00%> (ø)
Zip/QuickZip.swift 100.00% <ø> (ø)
Zip/ZipCompression.swift 100.00% <100.00%> (ø)
Zip/ZipError.swift 100.00% <100.00%> (ø)
Zip/ZipUtilities.swift 100.00% <100.00%> (ø)
Zip/Zip.swift 92.85% <91.66%> (ø)

Copy link

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fpseverino fpseverino merged commit 32b3e3e into vapor-community:main Aug 19, 2024
10 checks passed
@fpseverino fpseverino deleted the update branch August 19, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants