Skip to content

Assignment 2 - LCR #2

Open
vanya-geo wants to merge 5 commits intomainfrom
assignment-2
Open

Assignment 2 - LCR #2
vanya-geo wants to merge 5 commits intomainfrom
assignment-2

Conversation

@vanya-geo
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding a completed jupyter notebook for assignment 2.

What did you learn from the changes you have made?

I learned some syntax around lm fitting and about the RMSPE measure of fit.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I had some challenges with putting the correct df shapes into the lm.fit(). It was the difference between df[[column1, column 2,..]] and df[column1, column 2,..].

How were these changes tested?

Restart the kernel and run all cells. Everything ran correctly.

A reference to a related issue in your repository (if applicable)

-- PS: I hope I got the git pull requests right. I mean for this to be a new pull request, not part of the previous one.

Checklist

  • [ X] I can confirm that my changes are working as intended

Copy link

@PatelVishakh PatelVishakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 2: Incomplete, Needs some changes.

Required changes:


Q2) I) Also Should explain what Positive, Negative and No association imply about the relationship with the response i.e. when model year increases on average the MPG goes down.

Q2) II) Should Also explain the plotted line represents the line of BEST FIT with respect to the mean of sum of squared errors. 



Q4) In the context of this module by RMSPE we are referring to Root Mean Square Prediction Error and not Percentage Error.

@vanya-geo
Copy link
Owner Author

Thank you for the feedback. I've made the changes you requested. All changes are marked with "EDIT: ".

Copy link

@PatelVishakh PatelVishakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 2 Complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants