Open
Conversation
PatelVishakh
suggested changes
Dec 4, 2025
PatelVishakh
left a comment
There was a problem hiding this comment.
Assignment 2: Incomplete, Needs some changes.
Required changes:
Q2) I) Also Should explain what Positive, Negative and No association imply about the relationship with the response i.e. when model year increases on average the MPG goes down.
Q2) II) Should Also explain the plotted line represents the line of BEST FIT with respect to the mean of sum of squared errors.
Q4) In the context of this module by RMSPE we are referring to Root Mean Square Prediction Error and not Percentage Error.
Owner
Author
|
Thank you for the feedback. I've made the changes you requested. All changes are marked with "EDIT: ". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding a completed jupyter notebook for assignment 2.
What did you learn from the changes you have made?
I learned some syntax around lm fitting and about the RMSPE measure of fit.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I had some challenges with putting the correct df shapes into the lm.fit(). It was the difference between df[[column1, column 2,..]] and df[column1, column 2,..].
How were these changes tested?
Restart the kernel and run all cells. Everything ran correctly.
A reference to a related issue in your repository (if applicable)
-- PS: I hope I got the git pull requests right. I mean for this to be a new pull request, not part of the previous one.
Checklist