Putting the Arena in the ArenaPool resets it #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the Arena is meant to be used as highlighted here
When using the ArenaPool, someone would have then to manually reset the Arena before returning it to the Pool
Which results in many repetitive code or worse, using the API wrong (e.g. putting the Arena in the ArenaPool before resetting it)
Looking at the description of the ArenaPool#Put method as described here
it makes me think that the intention was that
ArenaPool#Putwould reset the pool