[WIP]Test scripts for check_stop_trading_abci #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
requested changes
Aug 9, 2024
There was a problem hiding this comment.
The behaviours code is not covered. Please check the pytest's cov report and update accordingly:
Name Stmts Miss Cover Missing
-------------------------------------------------------------------------------------------------------
packages/valory/skills/check_stop_trading_abci/__init__.py 2 0 100%
packages/valory/skills/check_stop_trading_abci/behaviours.py 86 50 42% 60, 65, 69-77, 91-136, 147-158, 162-170
Comment on lines
148
to
149
| # Execute the generator and retrieve the final return value | ||
| staking_kpi_met_gen = behaviour.is_staking_kpi_met() |
There was a problem hiding this comment.
The generator is never iterated upon.
There was a problem hiding this comment.
Okay i will try to improve the scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is dedicated to writing and refining test scripts for the check_stop_trading_abci function.