[DO NOT MERGE] Try to use docker with macOS on GitHub CI #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofavorito
force-pushed
the
fix/macos-docker
branch
from
e9694f3 to
c4fefe6
Compare
marcofavorito
force-pushed
the
fix/macos-docker
branch
from
c4fefe6 to
8e9540a
Compare
marcofavorito
commented
Jul 31, 2022
Comment on lines
+259
to
+264
| # install docker (macOS specific) | ||
| HOMEBREW_NO_AUTO_UPDATE=1 brew install --cask docker | ||
| sudo /Applications/Docker.app/Contents/MacOS/Docker --unattended --install-privileged-components | ||
| open -a /Applications/Docker.app --args --unattended --accept-license | ||
| echo "We are waiting for Docker to be up and running. It can take over 2 minutes..." | ||
| while ! /Applications/Docker.app/Contents/Resources/bin/docker info &>/dev/null; do sleep 1; done |
There was a problem hiding this comment.
this is the original shell code snippet (actions/runner#1456 (comment)) to install Docker on macOS runner.
I would like to improve the last while-loop to have a maximum number of iterations; otherwise it might loop forever (or at the maximum allowed time as per CI configuration).
|
The |
DavidMinarsch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR aims at restoring Docker-based tests on macOS runner on GitHub CI.
Unfortunately, Docker is not installed by default on macOS runners due to licensing issues: https://github.com/orgs/community/discussions/25777#discussioncomment-3249229
To install Docker from the macOS shell, there exist this shell snippet: actions/runner#1456 (comment). The only problem is that it takes more than 3 minutes to make
dockerbinary available and executable.Fixes
n/a
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments
n/a